Skip to content

Strict in_array check as per WP coding standards and use WordPress checked #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tangrufus wants to merge 2 commits into from
Closed

Strict in_array check as per WP coding standards and use WordPress checked #17

tangrufus wants to merge 2 commits into from

Conversation

@tangrufus
Copy link
Contributor

@tangrufus tangrufus commented Sep 8, 2017 •
edited
Loading

@dmchale
Copy link
Owner

dmchale commented Sep 9, 2017

Rejecting this one only due to personal preference of avoiding the one-liner as it was written here. For readability I kept the function call, and broke up the in_array() and checked() functions into their own lines. I also made sure to include the strict param in in_array(). Commit: 66e8cbb

@dmchale dmchale closed this Sep 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tangrufus @dmchale